-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS4 Upgrade **** WORK IN PROGRESS **** #48
base: master
Are you sure you want to change the base?
Conversation
… to be on Event to keep SS4 happy
…ix JavaScript calendar
@gordonbanderson just curious what the current status of this is. I haven't seen anyone comment on merging this or starting a new branch for SS4. Do you have this in a working version for SS4 that is downloadable or install-able via composer? |
I'm also intrested to know the state of this PR. Wouldn't it make sense to create a branch out of it? |
@chriszuercher I don't know how to make a branch out of it...but if someone can and make it installable via Composer that would be great! I don't even know how to view this versions code!!! |
How can I get my hands on this code? |
hi, Apologies for the slow response but my focus is not on programming at the moment. Unfortunately my father passed away recently and I am helping mum transition into the next stage of her life, and have effectively become the DIY guy and gardener for now. You can install this module with composer as follows:
composer require "titledk/silverstripe-calendar" "dev-upgradess4" It works but I've only installed it on one site, and it feels rough around the edges. There is a lack of unit testing, something I've not had time to add, and I think this module needs it as it's somewhat complicated. I was also having to guess some of the functionality as per the original post of this PR. The 3.x version of the module had a lot of configuration options (too many, and like the comments module it can lead to unnecessary complexity), checking the server install I'm running with the default configuration as per the module. Regards Gordon |
There is a bootstrap 4 compatible theme here https://github.com/gordonbanderson/silverstripe-events-theme, but I've not tested it in isolation, as I overrode some templates with the client theme. If either of you wish to open PRs againt these branches I will try and be more diligent in my GitHub notification watching, I am normally at my computer in the evenings UK time. |
@gordonbanderson I've followed your steps and cannot get this to install on a SS4.2 installation. Any tips? I've followed your instructions to the T and nada...still spits out that something in the module is looking for the old framework, not the recipe. |
What exactly was the problem you got? There is an error above, the JSON should be
(the closure of the array was missing). It's installing but erroring out when I try to add an event, looking into it |
@gordonbanderson I finally got this installed. Thanks for your help. A couple minor issues I have noticed.
|
I've been able to successfully get everything working in the CMS, but nothing, and I mean nothing, loads on the front end. Any thoughts? |
hi,
I have this apparently working with SilverStripe 4, but I am a little unsure of all the intended functionality due to the lack of documentation. For example I have no idea what a shaded calendar is, and there are contradictory references to private events being possible or not possible. As such could you have a look at this attempt and see if anything is awry?
Cheers
Gordon